issue-220: Fixes ttl-writetime auto flag handling #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvy
requested review from
jeromatron,
pravinbhat,
msmygit and
faizalrub-datastax
faizalrub-datastax
approved these changes
Dec 11, 2023
arvy
commented
Dec 11, 2023
| @@ -101,9 +101,17 @@ spark.cdm.connect.target.password cassandra | |||
| # columns need to be listed. | |||
| #----------------------------------------------------------------------------------------------------------- | |||
| spark.cdm.schema.origin.keyspaceTable keyspace_name.table_name | |||
|
|
|||
| # Max TTL value of all non-PK columns will be used for insert on target | |||
There was a problem hiding this comment.
non-PK columns might not be specific enough - not all types support writetime/ttl (collections, counters, etc..). ..so maybe "all ttl-eligible columns" would be a better description..
There was a problem hiding this comment.
Agree. May be "all ttl-eligible non-PK columns" ?
pravinbhat
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Looks good but it will still fail the coverage check due to build issues. Once PR #228 is merged, this should work. You will need to pull changes from main & then merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes ttl-writetime feature auto flag handling and some tests.
Which issue(s) this PR fixes:
Fixes #220
Checklist: