Skip to content

Commit

Permalink
Counter table fix & docker build info for local docker test.
Browse files Browse the repository at this point in the history
  • Loading branch information
pravinbhat committed Dec 16, 2023
1 parent 09d6f13 commit ea959cb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
9 changes: 9 additions & 0 deletions SIT/environment.sh
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,17 @@ _Setup() {

if [ "$(_testDockerCDM)" != "yes" ]; then
dockerContainerVersion=datastax/cassandra-data-migrator:${CDM_VERSION}

# Uncomment the below 'docker build' lines when making docker changes to ensure you test the docker changes
# Also comment the 'docker pull' line when 'docker build' is uncommented.
# Note this ('docker build') should be done only when testing docker changes locally (i.e. Do not commit)
# If you commit the 'docker build' step, the build will work but it will take too long as each time it will build
# CDM docker image instead of just downloading from DockerHub.
_info "Pulling latest Docker container for ${dockerContainerVersion}"
docker pull ${dockerContainerVersion}
# _info "Building latest Docker container for ${dockerContainerVersion}"
# docker build -t ${dockerContainerVersion} ..

_info "Starting Docker container ${DOCKER_CASS}"
docker run --name ${DOCKER_CDM} --network ${NETWORK_NAME} --ip ${SUBNET}.3 -e "CASS_USERNAME=${CASS_USERNAME}" -e "CASS_PASSWORD=${CASS_PASSWORD}" -e "CASS_CLUSTER=${DOCKER_CASS}" -d ${dockerContainerVersion}
attempt=1
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/datastax/cdm/feature/WritetimeTTL.java
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ public boolean initializeAndValidate(CqlTable originTable, CqlTable targetTable)
logger.error("Counter table cannot specify TTL or WriteTimestamp columns as they cannot set on write");
isValid = false;
isEnabled = false;
return false;
}

logger.info("Counter table does not support TTL or WriteTimestamp columns as they cannot set on write, so feature is disabled");
Expand Down

0 comments on commit ea959cb

Please sign in to comment.