Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adb-exfiltration-protection to use azurerm v4 #150

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

r3stl355
Copy link
Contributor

One of several updates to existing templates to make them compatible with azurerm v4, tracked in #144

Changes:

  • Add subscription_id parameter: it is mandatory in azurerm v4
  • Remove no_public_ip: it is true by default in azurerm v4
  • Move the Teraform required module declaration to providers.tf for consistency with other modules
  • Reduce output variables, some are part just inputs
  • Update README.md
  • Make corresponding and similar changes to modules/adb-exfiltration-protection

@r3stl355 r3stl355 requested review from a team as code owners November 15, 2024 15:34
@alexott
Copy link
Collaborator

alexott commented Nov 17, 2024

@r3stl355 I agree about your comment that this is too coarse grained - we have #99 and #88 for relevant parts

@alexott alexott merged commit b07bada into databricks:main Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants