ci: improve build times for instrumentation image tests #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not actually need to start a whole framework with an HTTP server to check one environment variable and exit. Also: - disable all auto-instrumentation by the Java agent for JVM instrumentation image tests - remove Node.js 18 Bullseye base image for Node.js tests All of this should help to speed up the instrumentation image tests.
basti1302
force-pushed
the
improve-instrumentation-test-build-times-for-jvm
branch
from
b4b9aff to
e29d6b2
Compare
basti1302
changed the title
basti1302
force-pushed
the
improve-instrumentation-test-build-times-for-jvm
branch
from
ae863f5 to
0a5e91b
Compare
This helps in particular with the check for changed files that decides whether or not to run this lengthy test suite: Previously, we would run it on any change of .github/workflows/ci.yaml, now we only run it when .github/actions/injector-and-instrumentation-tests/action.yaml has changes (and of course if there are changes images/instrumentation).
basti1302
force-pushed
the
improve-instrumentation-test-build-times-for-jvm
branch
from
0a5e91b to
088d567
Compare
|
basti1302
deleted the
improve-instrumentation-test-build-times-for-jvm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(instrumentation): convert Spring boot test apps to simple Java apps:
We do not actually need to start a whole framework with an HTTP server to check one environment variable and exit.
Also:
All of this should help to speed up the instrumentation image tests.