feat: restore k8s.replicaset.* metrics by keeping only non-zero values #252
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
reviewed
Feb 1, 2025
| k8s.replicaset.available: | ||
| enabled: false | ||
| enabled: true |
There was a problem hiding this comment.
nitpick: there is no need to set them to true explicitly, we should just remove the four lines 100-103 entirely, as these two metrics are enabled by default.
basti1302
reviewed
Feb 1, 2025
…ero values This removes noisy replicaset metrics while keeping the ones that actually have value. By default, Kubernetes keeps a history of 10 replicasets for each deployment, collecting metrics about all of them leads to a lot of metric datapoints with no value. Removing zero-value datapoints makes sure the backend knows about the actual active replicaset (with desired > 0).
basti1302
force-pushed
the
k8s-noisy-metrics
branch
from
351e080 to
b90e311
Compare
|
basti1302
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.