Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17179 test: Fix stop commands with trailing space #15993

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

phender
Copy link
Contributor

@phender phender commented Feb 27, 2025

Remove any trailing space from cmocka commands to ensure they can be properly stopped in tearDown.

Test-tag: DaosCoreTestDfuse HarnessCmockaTest CsumErrorLog DaosCoreTestDfs DaosCoreTestNvme DaosCoreTestRebuild DaosCoreTest CatRecovCoreTest
Skip-unit-tests: true
Skip-fault-injection-test: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Remove any trailing space from cmocka commands to ensure they can be
properly stopped in tearDown.

Test-tag: DaosCoreTestDfuse HarnessCmockaTest CsumErrorLog DaosCoreTestDfs DaosCoreTestNvme DaosCoreTestRebuild DaosCoreTest CatRecovCoreTest
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender requested review from a team as code owners February 27, 2025 23:11
Copy link

github-actions bot commented Feb 27, 2025

Ticket title is 'Extra spaces in command string causes stop to fail'
Status is 'Open'
Labels: 'scrubbed_2.8,testp2'
https://daosio.atlassian.net/browse/DAOS-17179

daltonbohning
daltonbohning previously approved these changes Feb 27, 2025
shimizukko
shimizukko previously approved these changes Feb 28, 2025
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15993/1/execution/node/814/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15993/2/execution/node/1147/log

@@ -28,7 +29,7 @@ def get_cmocka_command(command, parameters=None):
"""
keywords = ["Process received signal", "stack smashing detected", "End of error message",
"buffer overflow detected"]
path, executable = os.path.split(command)
path, executable = os.path.split(command.strip())
Copy link
Contributor Author

@phender phender Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not working:

2025-02-28 23:57:51,579 run_utils        L0471 DEBUG| Running on wolf-309 with a 60 second timeout: /usr/bin/pgrep --list-full --full -x '/usr/bin/daos_test -n /var/tmp/daos_testing/configs/daos_control.yml -m '
2025-02-28 23:57:51,793 run_utils        L0333 DEBUG|   wolf-309 (rc=1): <no output>

from https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15993/2/artifact/Functional%20Hardware%20Medium%20Verbs%20Provider/daos_test/suite.py/job.log
There is still a space at the end of:

-x '/usr/bin/daos_test -n /var/tmp/daos_testing/configs/daos_control.yml -m '

@phender phender marked this pull request as draft March 6, 2025 22:37
phender added 2 commits March 6, 2025 17:38
Test-tag: DaosCoreTest
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender dismissed stale reviews from shimizukko and daltonbohning via 4398614 March 7, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants