-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-17179 test: Fix stop commands with trailing space #15993
base: master
Are you sure you want to change the base?
Conversation
Remove any trailing space from cmocka commands to ensure they can be properly stopped in tearDown. Test-tag: DaosCoreTestDfuse HarnessCmockaTest CsumErrorLog DaosCoreTestDfs DaosCoreTestNvme DaosCoreTestRebuild DaosCoreTest CatRecovCoreTest Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
Ticket title is 'Extra spaces in command string causes stop to fail' |
Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15993/1/execution/node/814/log |
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15993/2/execution/node/1147/log |
@@ -28,7 +29,7 @@ def get_cmocka_command(command, parameters=None): | |||
""" | |||
keywords = ["Process received signal", "stack smashing detected", "End of error message", | |||
"buffer overflow detected"] | |||
path, executable = os.path.split(command) | |||
path, executable = os.path.split(command.strip()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not working:
2025-02-28 23:57:51,579 run_utils L0471 DEBUG| Running on wolf-309 with a 60 second timeout: /usr/bin/pgrep --list-full --full -x '/usr/bin/daos_test -n /var/tmp/daos_testing/configs/daos_control.yml -m '
2025-02-28 23:57:51,793 run_utils L0333 DEBUG| wolf-309 (rc=1): <no output>
from https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15993/2/artifact/Functional%20Hardware%20Medium%20Verbs%20Provider/daos_test/suite.py/job.log
There is still a space at the end of:
-x '/usr/bin/daos_test -n /var/tmp/daos_testing/configs/daos_control.yml -m '
Test-tag: DaosCoreTest Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
Remove any trailing space from cmocka commands to ensure they can be properly stopped in tearDown.
Test-tag: DaosCoreTestDfuse HarnessCmockaTest CsumErrorLog DaosCoreTestDfs DaosCoreTestNvme DaosCoreTestRebuild DaosCoreTest CatRecovCoreTest
Skip-unit-tests: true
Skip-fault-injection-test: true
Steps for the author:
After all prior steps are complete: