DAOS-16834 test: tags.py config option #15983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support in tags.py to dump tests associated with tags and/or paths. Add TagSet to handle negative matching. E.g. foo,-bar Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>
Add data command line option to tags.py to list test yaml data. Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
|
Ticket title is 'Support running existing tests in MD on SSD stages with two pool variants' |
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
src/tests/ftest/tags.py
Outdated
Comment on lines
742
to
744
| elif "weekly_regression" in tags: | ||
| return "weekly" | ||
| return "manual" |
There was a problem hiding this comment.
Probably should check if manual is in tags first so this function doesn't make unnecessary assumptions
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
src/tests/ftest/tags.py
Outdated
| "-v", "--verbose", | ||
| action='store_true', | ||
| help="print verbose output") | ||
|
|
||
| args = parser.parse_args() | ||
| args.paths = list(map(os.path.realpath, args.paths)) |
There was a problem hiding this comment.
This doesn't work now with the subparsers that don't have paths. E.g.
./src/tests/ftest/tags.py unit
Traceback (most recent call last):
File "/home/dbohning/daos-stack/daos/./src/tests/ftest/tags.py", line 959, in <module>
sys.exit(main())
File "/home/dbohning/daos-stack/daos/./src/tests/ftest/tags.py", line 933, in main
args.paths = list(map(os.path.realpath, args.paths))
AttributeError: 'Namespace' object has no attribute 'paths'
There was a problem hiding this comment.
Ah, right. I meant to make that conditional.
Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
|
You'll want to merge in master now that mine is merged |
phender
changed the title
Test-tag: test_always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
shimizukko
previously approved these changes
Feb 28, 2025
src/tests/ftest/tags.py
Outdated
| ftest python files. | ||
| list (set, optional): list of sets of tags used to filter displayed tests. Defaults to no | ||
| filtering. | ||
| list (set, optional): list of sets of test yaml data keys to display. Defaults to None, |
There was a problem hiding this comment.
Suggested change
| list (set, optional): list of sets of test yaml data keys to display. Defaults to None, | |
| keys (set, optional): list of sets of test yaml data keys to display. Defaults to None, |
Test-tag: test_always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>
shimizukko
approved these changes
Mar 2, 2025
| Returns: | ||
| list: values found for the key | ||
| """ | ||
| self.__display(f"__filter_value: key_path={key_path}, key_types={key_types}") |
There was a problem hiding this comment.
I think it's better to not leave this debug here. Especially since it requires a helper method + new argument in init. This is only ever needed if there is a bug. And to guard against bugs its better to have unit tests than debug printouts
daltonbohning
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config command line option to tags.py to list test yaml data.
Test-tag: always_passes
Skip-unit-tests: true
Skip-fault-injection-test: true
Steps for the author:
After all prior steps are complete: