Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16898 cq: support user bash in githooks (#15648) #15892

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
Open

DAOS-16898 cq: support user bash in githooks (#15648) #15892

wants to merge 1 commit into from

Conversation

daltonbohning
Copy link
Contributor

Replace hardcoded /bin/bash with /usr/bin/env bash in the githook scripts, for the case where /bin/bash does not support newer features like, e.g., mapfile.

replace mapfile with loop in get_release_branch

Skip-test: true
Skip-tests: true
SKip-unit-tests: true
Skip-nlt: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-16898 cq: support user bash in githooks (#15648)
93b14e4 
Replace hardcoded /bin/bash with /usr/bin/env bash in the githook
scripts, for the case where /bin/bash does not support newer features
like, e.g., mapfile.

replace mapfile with loop in get_release_branch

Skip-test: true
Skip-tests: true
SKip-unit-tests: true
Skip-nlt: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Feb 12, 2025
@daltonbohning daltonbohning self-assigned this Feb 12, 2025
@github-actions GitHub Actions
Copy link

Ticket title is 'githooks: support user bash'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16898

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Feb 12, 2025
@daltonbohning daltonbohning marked this pull request as ready for review February 13, 2025 18:38
@daltonbohning daltonbohning requested a review from a team as a code owner February 13, 2025 18:38
@daltonbohning daltonbohning requested a review from a team February 13, 2025 21:25
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 13, 2025
@daltonbohning daltonbohning removed the request for review from a team February 25, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpadma2 rpadma2 rpadma2 approved these changes

@phender phender phender approved these changes

@liw liw Awaiting requested review from liw

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @rpadma2 @phender