Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16971 cart: add origin address to RPC debug log #15825

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+111 −35
Open

DAOS-16971 cart: add origin address to RPC debug log #15825

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64adbc4
DAOS-16971 cart: add origin address to RPC debug log
wangdi1 Jan 31, 2025
f7bf078
DAOS-16971 cart: fix mem leak
wangdi1 Jan 31, 2025
a5a5437
DAOS-16971 object: revert some message
wangdi1 Feb 1, 2025
c9b8edd
DAOS-16971 cart: fix style
wangdi1 Feb 1, 2025
02af403
Merge branch 'master' into wangdi/daos_16971_rpc_debug
wangdi1 Feb 6, 2025
96e2eca
DAOS-16971 cart: update the patch
wangdi1 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DAOS-16971 object: revert some message 
Revert some log changes to please CI

Signed-off-by: Di Wang <ddiwang@google.com>
@wangdi1
wangdi1 committed Feb 1, 2025
commit a5a543730ec617cadd2fdbb66c0f7609a7f7be47
6 changes: 2 additions & 4 deletions src/object/srv_obj.c
View file
Original file line number Diff line number Diff line change
@@ -184,10 +184,8 @@ obj_rw_reply(crt_rpc_t *rpc, int status, uint64_t epoch, bool release_input,
orwo->orw_epoch = max(epoch, orwo->orw_epoch);
}

DL_CDEBUG(status == 0 || obj_retry_error(status), DB_IO, DLOG_ERR, status,
"rpc %p:%s opc %d send reply, pmv %d, epoch " DF_X64 ", status %d\n", rpc,
crt_rpc_get_origin_addr(rpc), opc_get(rpc->cr_opc), ioc->ioc_map_ver,
orwo->orw_epoch, status);
D_DEBUG(DB_IO, "rpc %p opc %d send reply, pmv %d, epoch " DF_X64 ", status %d\n", rpc,
opc_get(rpc->cr_opc), ioc->ioc_map_ver, orwo->orw_epoch, status);

if (!ioc->ioc_lost_reply) {
if (release_input)

Unchanged files with check annotations Beta

View file
src/cart/crt_bulk.c
rc = crt_hg_bulk_transfer(bulk_desc, complete_cb, arg, opid, true);
if (rc != 0)
DL_ERROR(rc, "%p:%s crt_hg_bulk_transfer() failed.\n", bulk_desc->bd_rpc,

Check warning on line 208 in src/cart/crt_bulk.c

GitHub Actions / Logging macro checking 

check-return, Line contains too many newlines
crt_rpc_get_origin_addr(bulk_desc->bd_rpc));
out: