Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16834 test: Support testing MD on SSD Phase 2 #15767
base: master
Are you sure you want to change the base?
DAOS-16834 test: Support testing MD on SSD Phase 2 #15767
Changes from 4 commits
c13d39c
af53a32
457c5de
ec0cf23
c3388e9
15983b3
94fb39e
4823354
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1146 in src/tests/ftest/util/launch_utils.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this mean that when we use "auto_md_on_ssd", EVERY test has its variants doubled? And then specifically ior and mdtest small run a further additional variant?
For this to work as intended I think we should not use
nvme: !mux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction, they still have their variants doubled. But the mux in their configs filters out variants so in total it's still doubled.
But this means other tests will have their variants doubled by the extra yaml, and they will not filter them out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running a test other than ior/mdtest small in the md on ssd stage would highlight this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. We should only add the
extra_yaml_launch_params.yaml
(with the mux) if we detect it being used as a filter, e.g. search the test yaml file for!filter-only : /run/launch/nvme
. I'll also add running an additional test on the next push.