Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16845 test: update tests to use check_free_space #15553

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

DAOS-16845 test: update tests to use check_free_space #15553

wants to merge 3 commits into from

Conversation

daltonbohning
Copy link
Contributor

@daltonbohning daltonbohning commented Dec 3, 2024 •
edited
Loading

Update tests to use pool.check_free_space to dynamically wait for pool aggregation.

Test-tag: test_enospace_time_with_fg DfuseSpaceCheck MultipleContainerDelete
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning [email protected]

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Ticket title is 'nvme/enospace.py:NvmeEnospace.test_enospace_time_with_fg - ior MPI_Abort No space left on device'
Status is 'In Review'
Labels: 'ci_2.6_weekly,weekly_test'
https://daosio.atlassian.net/browse/DAOS-16845

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15553/1/execution/node/936/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15553/2/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-16845 branch 2 times, most recently from 6cb9368 to 95c74d7 Compare December 4, 2024 16:23
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15553/5/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-16845 branch 3 times, most recently from 6d8f4b9 to 1969be3 Compare January 8, 2025 22:23
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15553/8/execution/node/926/log

@daltonbohning daltonbohning changed the title DAOS-16845 test: add dynamic pool wait_for_aggregation DAOS-16845 test: update tests to use check_free_space Jan 30, 2025
@daltonbohning daltonbohning force-pushed the dbohning/daos-16845 branch 2 times, most recently from ab53a47 to d946766 Compare January 30, 2025 22:28
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15553/11/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-16845 branch 2 times, most recently from 14a40d4 to 03103ab Compare February 13, 2025 20:26
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15553/13/execution/node/926/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15553/14/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-16845 branch 2 times, most recently from 6940434 to 72c2f37 Compare February 21, 2025 22:37
@daltonbohning
DAOS-16845 test: update tests to use check_free_space
a520737 
Update tests to use pool.check_free_space to dynamicall wait for pool aggregation.

Test-tag: test_enospace_time_with_fg DfuseSpaceCheck MultipleContainerDelete
Test-repeat: 3
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning
daltonbohning commented Feb 25, 2025
View reviewed changes
src/tests/ftest/nvme/enospace.yaml
Comment on lines +62 to +63
aggregation:
scm_threshold_percent: 99 # percent of scm expected to be reclaimed after aggregation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be standard for other tests too. E.g.

daos/src/tests/ftest/erasurecode/restart.yaml

Lines 56 to 57 in 6246853

aggregation:
threshold: "70%"

@daltonbohning daltonbohning marked this pull request as ready for review February 25, 2025 17:26
@daltonbohning daltonbohning requested a review from a team as a code owner February 25, 2025 17:26
@daltonbohning daltonbohning requested a review from a team as a code owner February 25, 2025 17:26
shimizukko
shimizukko previously approved these changes Feb 25, 2025
View reviewed changes
knard38
knard38 reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have locally tested as I was afraid that dmg pool query was not providing the "real" available size.
At the end, it seems to be trustful :-)
However, it would also a good thing to also change the other time.sleep(60) from line 588 of the file enospace.py

phender
phender previously approved these changes Feb 26, 2025
View reviewed changes
@daltonbohning
also update test_enospace_lazy_with_fg
46591f9 
Test-tag: test_enospace_time_with_fg DfuseSpaceCheck MultipleContainerDelete test_enospace_lazy_with_fg
Test-repeat: 3
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning dismissed stale reviews from phender and shimizukko via 46591f9 February 26, 2025 16:11
@daltonbohning
Copy link
Contributor Author

I have locally tested as I was afraid that dmg pool query was not providing the "real" available size. At the end, it seems to be trustful :-) However, it would also a good thing to also change the other time.sleep(60) from line 588 of the file enospace.py

Gah I overlooked that one. Updated. Testing now

shimizukko
shimizukko previously approved these changes Mar 4, 2025
View reviewed changes
knard38
knard38 previously approved these changes Mar 4, 2025
View reviewed changes
phender
phender previously approved these changes Mar 4, 2025
View reviewed changes
@daltonbohning daltonbohning requested a review from a team March 4, 2025 14:58
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Mar 4, 2025
@daltonbohning daltonbohning removed the request for review from a team March 4, 2025 14:58
@daltonbohning
Copy link
Contributor Author

Need to resolve conflicts now

@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-16845
860b76e 
Test-tag: test_enospace_time_with_fg DfuseSpaceCheck MultipleContainerDelete test_enospace_lazy_with_fg
Test-repeat: 1
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning dismissed stale reviews from phender, knard38, and shimizukko via 860b76e March 4, 2025 15:01
@daltonbohning daltonbohning requested a review from shimizukko March 7, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimizukko shimizukko shimizukko approved these changes

@phender phender phender approved these changes

@knard38 knard38 knard38 left review comments

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daltonbohning @daosbuild1 @shimizukko @phender @knard38