Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16072 test: Support non-root user client commands #14670

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

DAOS-16072 test: Support non-root user client commands #14670

wants to merge 16 commits into from

Conversation

phender
Copy link
Contributor

@phender phender commented Jun 28, 2024 •
edited
Loading

Support running commands on client hosts w/o sudo permissions.

  • Add new launch.py command line arguments to specify a non-root daos_agent user
  • Disable using sudo for fault injection file removal

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_launch_failures

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-16072 test: Support non-root user client commands
5050150 
Support running commands on client hosts w/o sudo permissions.
- Add new launch.py command line arguments to specify a non-root
  daos_agent user

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_launch_failures

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Ticket title is 'ftest: support starting daos_agent with systemctl --user'
Status is 'In Progress'
Labels: 'daos_framework'
https://daosio.atlassian.net/browse/DAOS-16072

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/1/execution/node/798/log

phender added 2 commits June 28, 2024 16:47
@phender
Additional fixes:
9c15811 
- Disable using sudo for fault injection file removal

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Revert unitended change to get_clush_command.
914a0b4 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
daltonbohning added a commit that referenced this pull request Jun 28, 2024
@daltonbohning
verbose cert copying from #14670
2089375 
Skip-test: true
Skip-build: true

Signed-off-by: Phil Henderson <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
@phender
Adding passing user to all ExecutableCommand classes.
02c81e3 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/4/execution/node/798/log

phender added 3 commits July 1, 2024 11:52
@phender
Fix setting DAOS_AGENT_DRPC_DIR.
c336fa2 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Renamed run_utils.py run_command to issue_command.
b420fdb 
Added passing agent_user into DaosAgentCommand.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Fix for test-specific temp dir.
1febf4e 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/7/execution/node/799/log

daltonbohning added a commit that referenced this pull request Jul 1, 2024
@daltonbohning
Adding passing user to all ExecutableCommand classes from #14670
084bbe2 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Jul 1, 2024
@daltonbohning
Renamed run_utils.py run_command to issue_command from #14670
c54bd7a 
Skip-test: true
Skip-build: true

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
@phender
Adding harness/coverage.py test.
5677583 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid test_basic_coverage

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
daltonbohning
daltonbohning reviewed Jul 1, 2024
View reviewed changes
src/tests/ftest/harness/coverage.py Outdated
def test_basic_coverage(self):
"""Test basic harness coverage by starting servers, agents, dfuse, and running ior.

:avocado: tags=all,daily_regression
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better to put as manual or in weekly

daltonbohning
daltonbohning reviewed Jul 1, 2024
View reviewed changes
src/tests/ftest/harness/coverage.yaml Outdated
Comment on lines 29 to 30
transfer_size: 64K
block_size: 128K
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially be super slow due to the VM slowness issue. I'd recommend reducing drastically to like 1K or less, but even that could be slow

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/8/execution/node/798/log

@phender
Fix new test.
a60236e 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid test_basic_coverage

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/9/execution/node/814/log

phender added 4 commits July 1, 2024 19:13
@phender
Remove additional sudo commands.
1a58566 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid test_basic_coverage

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Additoinal change:
1720530 
- Adding support for specifying a specific LD_LIBRARY_PATH to use in the
daos_server config environment variables for eeach engine.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid test_basic_coverage

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Updates to daos_server LD_LIBRARY_PATH.
f019883 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: test_valid_labels test_snapshots test_container_label_valid test_basic_coverage

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Cleanup run_utils.py
07bbf4f 
- Initial removal of run_command

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: pr test_valid_labels test_snapshots test_container_label_valid test_basic_coverage HarnessUnitTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/13/execution/node/284/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/13/execution/node/398/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/13/execution/node/395/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/13/execution/node/327/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/13/execution/node/494/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/13/execution/node/383/log

phender added 3 commits July 9, 2024 22:41
@phender
Sync changes.
223e2c7 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: pr test_valid_labels test_snapshots test_container_label_valid test_basic_coverage HarnessUnitTest DdbTest test_container_basics

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Merge branch 'master' into pahender/DAOS-16072_2
511fe57 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: pr test_valid_labels test_snapshots test_container_label_valid test_basic_coverage HarnessUnitTest DdbTest test_container_basics

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Merge branch 'master' into pahender/DAOS-16072_2
ec99ecc 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Test-tag: pr test_valid_labels test_snapshots test_container_label_valid test_basic_coverage HarnessUnitTest DdbTest test_container_basics

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14670/16/execution/node/823/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phender @daosbuild1 @daltonbohning