Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15234 test: Moving to Avocado 103 LTS #14148

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

DAOS-15234 test: Moving to Avocado 103 LTS #14148

wants to merge 16 commits into from

Conversation

phender
Copy link
Contributor

@phender phender commented Apr 10, 2024

Moving to the latest avocado LTS release.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Doc-only: false

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-15234 test: Moving to Avocado 103 LTS
d16d2b5 
Moving to the latest avocado LTS release.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Doc-only: false

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Ticket title is 'Update to newer avocado LTS release.'
Status is 'In Progress'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-15234

phender
phender commented Apr 10, 2024
View reviewed changes
requirements-ftest.txt
avocado-framework==82
avocado-framework-plugin-result-html==82
avocado-framework-plugin-varianter-yaml-to-mux==82
avocado-framework>=103.0,<104.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This range ensures we pick up any dot fixes to the 103 LTS release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ==103 not allow any 103.x point release? That was my experience with ==82.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://peps.python.org/pep-0440/#version-matching it looks like we could use ==103.*.

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/1/execution/node/739/log

@phender
Avocado 103 LTS needs a minimum of python 3.7.
0b58ae1 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Doc-only: false

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/2/execution/node/734/log

@phender
Move python3.12 install command.
fef1bd3 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-el9: false
Skip-func-test-leap15: false
Doc-only: false
Test-tag: pr,-rebuild

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/3/execution/node/768/log

@phender
Run the virtual env with the latest available python version installed.
01c5b20 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-el9: false
Skip-func-test-leap15: false
Doc-only: false
Test-tag: pr,-rebuild

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/4/execution/node/763/log

phender added 2 commits April 11, 2024 11:30
@phender
Merge branch 'master' into pahender/DAOS-15234
c0a579d
@phender
Fix typo.
b75c87d 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-el9: false
Skip-func-test-leap15: false
Doc-only: false
Test-tag: pr,-rebuild

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/5/execution/node/711/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/5/execution/node/833/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/5/execution/node/820/log

ashleypittman
ashleypittman reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@ashleypittman ashleypittman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pylint changes in this PR are due to changes to the Avocado API between versions so they all need updating.

I assume you're aware that the Jenkins lightweight images run launch.py to detect the test list and they are using 82 so any changes made will need to be backwards compatible as well, at least until the lightweight images can be updated.

src/tests/ftest/scripts/main.sh Outdated
@@ -22,7 +22,8 @@ then
rm -rf venv
fi

python3 -m venv venv
latest_python=$(find /usr/bin -name 'python*' -type f -executable | grep -E '[0-9]$' | sort -r | head -1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option would be to call update-alternatives after installing a later version at https://github.com/daos-stack/daos/blob/master/ci/provisioning/post_provision_config_nodes_EL_8.sh#L23

I think we concluded that my PR installed python3.9 on EL8 but actually it didn't need to so you could also try removing that.

requirements-ftest.txt
avocado-framework==82
avocado-framework-plugin-result-html==82
avocado-framework-plugin-varianter-yaml-to-mux==82
avocado-framework>=103.0,<104.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ==103 not allow any 103.x point release? That was my experience with ==82.

@phender
Code updates for 103 LTS.
8d06a9d 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-el9: false
Skip-func-test-leap15: false
Doc-only: false
Test-tag: pr,-rebuild

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Copy link
Contributor Author

phender commented Apr 11, 2024

I assume you're aware that the Jenkins lightweight images run launch.py to detect the test list and they are using 82 so any changes made will need to be backwards compatible as well, at least until the lightweight images can be updated.

I would have assumed that too, but I'm seeing Avocado 92.1 being used:

[2024-04-11T15:54:41.934Z] + ./launch.py --list --verbose pr,-rebuild,vm
[2024-04-11T15:54:41.934Z] --------------------------------------------------------------------------------
[2024-04-11T15:54:41.934Z] DAOS functional test launcher
[2024-04-11T15:54:41.934Z] 
[2024-04-11T15:54:41.934Z] Running with Avocado 92.1 on python 3.12.2 (main, Feb 21 2024, 00:00:00) [GCC 13.2.1 20231205 (Red Hat 13.2.1-6)]
[2024-04-11T15:54:41.934Z] Launch job results directory:  /var/tmp/ftest/avocado/job-results/launch/functional_on_el_8.8
[2024-04-11T15:54:41.934Z]   Renamed existing launch job results directory to /var/tmp/ftest/avocado/job-results/launch/functional_on_el_8.8_old
[2024-04-11T15:54:41.934Z] Launch log file:               /var/tmp/ftest/avocado/job-results/launch/functional_on_el_8.8/job.log
[2024-04-11T15:54:41.934Z] --------------------------------------------------------------------------------

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/6/execution/node/768/log

@phender
Fix missed pylint issue.
117482c 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-el9: false
Skip-func-test-leap15: false
Doc-only: false
Test-tag: pr,-rebuild PosixSimul

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/7/execution/node/764/log

@phender
Fix arguments-renamed error.
23f3259 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-el9: false
Skip-func-test-leap15: false
Doc-only: false
Test-tag: pr,-rebuild PosixSimul

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/8/execution/node/769/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/8/execution/node/837/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/8/execution/node/824/log

@ashleypittman ashleypittman mentioned this pull request Apr 12, 2024
Merged
18 tasks
phender added 3 commits April 23, 2024 20:32
@phender
Merge branch 'master' into pahender/DAOS-15234
fb83c38
@phender
Merge branch 'master' into pahender/DAOS-15234
006f8aa 
Signed-off-by: Phil Henderson <[email protected]>
@phender
Use python3.11.
f6d4c65 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-leap15: false
Skip-func-test-el9: false
Test-tag: always_passes test_setup_vm test_core_files PosixSimul EcodSpaceUsage

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/9/execution/node/805/log

@phender
More testing.
d43b684 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-leap15: false
Skip-func-test-el9: false
Test-tag: pr,-cart

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/10/execution/node/890/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/10/execution/node/821/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/10/execution/node/805/log

phender added 2 commits May 31, 2024 17:25
@phender
Merge branch 'master' into pahender/DAOS-15234
8dd13a3
@phender
Fix leap
e14207f 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-leap15: false
Skip-func-test-el9: false
Test-tag: pr,-cart

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/11/execution/node/805/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/11/execution/node/854/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/11/execution/node/870/log

@phender
Adding missed change.
5446200 
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
Skip-func-test-leap15: false
Skip-func-test-el9: false
Test-tag: pr,-cart

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/12/execution/node/805/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/12/execution/node/854/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14148/12/execution/node/870/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleypittman ashleypittman ashleypittman left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phender @daosbuild1 @ashleypittman