Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome: update to GNOME 46 #357

Merged
merged 2 commits into from
May 9, 2024
Merged

gnome: update to GNOME 46 #357

merged 2 commits into from
May 9, 2024

Conversation

danth
Copy link
Owner

@danth danth commented May 6, 2024

No description provided.

@danth danth enabled auto-merge (squash) May 6, 2024 13:20
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the cursor supposed to be a block: image

Also, the testbed-gnome-dark testbed runs extremely slow with this PR. Would increasing the CPU and RAM resolve this?

@danth
Copy link
Owner Author

danth commented May 8, 2024

Is the cursor supposed to be a block

No, it's not. There seems to be an issue with the cursor configuration.

I've seen the same situation before when someone swapped from KDE to GNOME and some state was left over in the home directory which set their cursor to a package which was no longer installed. This cannot be the issue here, since the VM is reset on every boot, but perhaps it's something similar.

Also, the testbed-gnome-dark testbed runs extremely slow with this PR. Would increasing the CPU and RAM resolve this?

This is most likely due to the lack of hardware acceleration for graphics, which is being worked on upstream in NixOS/nixpkgs#279009.

@danth
Copy link
Owner Author

danth commented May 8, 2024

Adding the following to testbed.nix makes the cursor appear correctly:

  stylix.cursor = {
    name = "Adwaita";
    package = pkgs.gnome.adwaita-icon-theme;
  };

So the issue seems to be that the cursor we use by default, that being Vanilla-DMZ, doesn't load properly in GNOME Shell any more.

Should we work on this in a follow-up PR?

@trueNAHO
Copy link
Collaborator

trueNAHO commented May 8, 2024

Should we work on this in a follow-up PR?

Maybe we should address it in this PR to avoid confusing users.

@danth
Copy link
Owner Author

danth commented May 9, 2024

The cursor issue occurs with the current version of Stylix too, when combined with GNOME 46 - so it wasn't introduced by the changes made here. It won't show up in the testbed for master yet since the master branch is currently pinned to an older nixpkgs revision, but it happens when using master with the latest nixpkgs.

Merging this now will fix some other visual issues due to the CSS being aimed at an older version of GNOME.

The only case where this could introduce new user facing issues is if the user is tracking our pinned nixpkgs, which is not something we currently recommend (since it's only bumped if necessary to make the tests pass).

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this now will fix some other visual issues due to the CSS being aimed at an older version of GNOME.

I guess we should just merge this PR then.

@danth danth merged commit 1975269 into master May 9, 2024
9 checks passed
@danth danth deleted the gnome-46 branch May 9, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants