Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Midi Out and getDeviceByName #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fashberg
Copy link

@fashberg fashberg commented Feb 7, 2021

Some Improvements

@dannywarren
Copy link
Owner

This is excellent, thank you! Will test this out later and merge, everything looks good at a glance though. Thank you again.

@fashberg
Copy link
Author

fashberg commented Feb 7, 2021

Hey @dannywarren,

FYI: i've needed MIDI out for this little weekend project:
https://github.com/fashberg/XTouchMini-Davinci-Resolve-Midi-Adapter

Kind Regards
Folke

@dannywarren
Copy link
Owner

Wow, this is really cool! The whole reason I wrote this was when I was trying to use an audio control surface with a NLVE, and I bumped in to the same limitations with not being able to feed MIDI back in to the parts of apps that already speak control surfaces. So you were able to push forward where I got stuck, that's awesome.

Thank you again, looking forward to playing with the changes later.

@dannywarren
Copy link
Owner

Just FYI, I still plan to merge this in the next few days. You happened to catch me right as I was tearing my MIDI setup apart. :)

@tiphedor
Copy link

If i may bump on this one - I'm using @fashberg's branch in a project of mine and everything works fine, it would be awesome to merge this PR ! :)

@dannywarren
Copy link
Owner

If i may bump on this one - I'm using @fashberg's branch in a project of mine and everything works fine, it would be awesome to merge this PR ! :)

I was actually thinking of picking this back up this weekend, great timing!

Apologies for letting this sit so long, I've had some health issues that have slowed me down this past year, but I have my studio set up again and should be ready to validate and merge this now.

But sounds like it's in great shape and doesn't need much validation if you're also using it - so I'll err on the side of just getting it merged. Thanks!

@tiphedor
Copy link

Thanks to yo for the lib ! :)

@@ -258,7 +407,21 @@ Class Midi
__OpenMidiIn( midiInDeviceId )
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to need Return between __SelectMidiInDevice end and before __SelectMidiOutDevice

Suggested change
Return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants