-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Midi Out and getDeviceByName #7
base: master
Are you sure you want to change the base?
Conversation
This is excellent, thank you! Will test this out later and merge, everything looks good at a glance though. Thank you again. |
Hey @dannywarren, FYI: i've needed MIDI out for this little weekend project: Kind Regards |
Wow, this is really cool! The whole reason I wrote this was when I was trying to use an audio control surface with a NLVE, and I bumped in to the same limitations with not being able to feed MIDI back in to the parts of apps that already speak control surfaces. So you were able to push forward where I got stuck, that's awesome. Thank you again, looking forward to playing with the changes later. |
Just FYI, I still plan to merge this in the next few days. You happened to catch me right as I was tearing my MIDI setup apart. :) |
If i may bump on this one - I'm using @fashberg's branch in a project of mine and everything works fine, it would be awesome to merge this PR ! :) |
I was actually thinking of picking this back up this weekend, great timing! Apologies for letting this sit so long, I've had some health issues that have slowed me down this past year, but I have my studio set up again and should be ready to validate and merge this now. But sounds like it's in great shape and doesn't need much validation if you're also using it - so I'll err on the side of just getting it merged. Thanks! |
Thanks to yo for the lib ! :) |
@@ -258,7 +407,21 @@ Class Midi | |||
__OpenMidiIn( midiInDeviceId ) | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to need Return
between __SelectMidiInDevice
end and before __SelectMidiOutDevice
Return | |
Some Improvements