Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.4.2 #71

Merged
merged 4 commits into from
Feb 13, 2021
Merged

Release/v0.4.2 #71

merged 4 commits into from
Feb 13, 2021

Conversation

danitso-dp
Copy link
Collaborator

@danitso-dp danitso-dp commented Feb 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

BUG FIXES:

* resource/virtual_environment_vm: Fix `disk.file_id` diff issue
* resource/virtual_environment_vm: Fix disk resizing issue

OTHER:

* provider/example: Remove support for Terraform v0.11 and older
* provider/makefile: Update to use plugin caching to support local builds

@danitso-dp
Copy link
Collaborator Author

@luhahn @mleone87 any chance you're up for testing this patch release? It should fix the issue with disk.file_id, which @mleone87 mentioned in #61

@danitso-dp
Copy link
Collaborator Author

I'm merging this now as it has been confirmed to work in multiple clusters with different owners.

@danitso-dp danitso-dp merged commit 69ff016 into master Feb 13, 2021
@danitso-dp danitso-dp deleted the release/v0.4.2 branch February 13, 2021 22:24
@mleone87
Copy link
Contributor

@danitso-dp I confirm that it works! How did you managed to fix that?

@danitso-dp
Copy link
Collaborator Author

@mleone87 a simple workaround was left out when redesigning the disk management code. The fix is to only overwrite the value in the state file, if we actually have a new value for it. Considering the file_id value isn't stored in Proxmox, we cannot retrieve the original value during state refresh hence we shouldn't try to overwrite it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants