Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple colour schemes in multiplot #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomReichardt
Copy link

This is my first pull request, please be kind.

@danieljprice
Copy link
Owner

I had a look at merging this. General idea and code looks good, I found a few issues in practice. Mainly that with tiled plots the colour scheme can change but there is a shared colour bar which only shows one scheme. Also, I think it makes more sense to have one colour bar per quantity rather than per plotting panel, which changes the logic in how the array is used. So I have not merged it into the 2.9.1 release, but with a bit of effort I will try to get it in the next one.

@TomReichardt
Copy link
Author

Mm, sure. That issue makes sense. I'd have to look into a way to spit up a colourbar if the schemes were not the same.
I did think about doing it per quantity, but I felt that per panel was a bit more general. You can effectively do a colourbar per quantity this way, but if you limit each quantity to strictly having their own colour scheme, then you can't render the same quantity in two different ways. Not sure why you'd WANT to do that, in practice, but somebody might. I guess one could use your workaround of creating a new quantity identical to the old one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants