User key feature #11
Open
User key feature #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 13, 2021 17:29
One of the issue of key management system is the fact that if we don't keep track of which person got what key we can effictively manage user on this kind of system That's why I added a new feature that will let admin use a DB to save the connection between a user and a key
This new PR is here to add a new feature that will allow a match between peer/CIDR with a username to facilitate the user management Some cleaning have been done too
|
|
||
| type User struct { | ||
| Username string `json:"username"` | ||
| Key string `json:"key"` |
There was a problem hiding this comment.
maybe you can use golint to avoid this kind of thing ;)
| } | ||
| case "delete": | ||
| if len(os.Args) < 3 { | ||
| return errors.New("issue with argument") |
There was a problem hiding this comment.
Maybe something more explicit ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the issue of Wireguard key management system is the fact that if we don't
keep track of which person got what key we can't effectively manage users
on this kind of system
That's why I added a new feature that will let admin use a DB to save the
connection between a user and a key/CIDR