Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "refactor: use timed animation to be non-blocking (#3671)" #4050

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Revert "refactor: use timed animation to be non-blocking (#3671)" #4050

merged 1 commit into from
Jan 7, 2025

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Jan 7, 2025 •
edited by github-actions bot
Loading

This reverts commit f17d1e0.

Changes

  • This reverts the usage of useTransition on toast notification that caused the laggy experience.
  • Tested locally and worked as intended.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://mi-715.preview.app.daily.dev

@sshanzel sshanzel marked this pull request as ready for review January 7, 2025 18:53
@sshanzel sshanzel requested a review from a team as a code owner January 7, 2025 18:53
@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 7, 2025 6:55pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 7, 2025 6:55pm

@sshanzel
Copy link
Member Author

sshanzel commented Jan 7, 2025

Tested on preview and worked as intended. To reproduce:

  • Use Grid view.
  • Click copy link.
  • Click the post to redirect.
  • App hangs.

Try the same step from the preview of this PR and it should not happen.

@sshanzel sshanzel enabled auto-merge (squash) January 7, 2025 19:09
AmarTrebinjac
AmarTrebinjac approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the flow which caused me to report this, doesn't lag there either.

@sshanzel sshanzel merged commit 2c1ceb5 into main Jan 7, 2025
11 checks passed
@sshanzel sshanzel deleted the MI-715 branch January 7, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmarTrebinjac AmarTrebinjac AmarTrebinjac approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshanzel @AmarTrebinjac