gerando readme.txt #586
Open
gerando readme.txt #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joellensilva
commented
Jan 27, 2025
joellensilva
commented
- depende retornando avisos dos órgãos do BD storage#143 (falta atualizar a versão)
- texto ainda em revisão pelo Cristiano
- gera um readme do pacote de dados, com avisos a partir da especificação do órgão (e ano/mês) através de query params
fonluiz
approved these changes
Feb 17, 2025
Comment on lines
+874
to
+881
| // Gravar o conteúdo atualizado no arquivo temporário | ||
| readmeFile = "readme_atualizado.txt" | ||
| err = os.WriteFile(readmeFile, newContent, 0644) | ||
| if err != nil { | ||
| return c.JSON(http.StatusInternalServerError, fmt.Errorf("erro ao gravar o arquivo temporário: %q", err)) | ||
| } | ||
| defer os.Remove(readmeFile) | ||
| } |
There was a problem hiding this comment.
Rever: Não entendi porque um arquivo temporário é salvo para depois ser removido. Se isso puder ser evitado, evitaríamos um acesso ao disco (muito demorado).
Comment on lines
+833
to
+835
| if err != nil { | ||
| return c.JSON(http.StatusBadRequest, fmt.Sprintf("Parâmetro ANO inválido: %s.", year)) | ||
| } |
There was a problem hiding this comment.
Dúvida: Por que em alguns lugares foi usado fmt.Errorf() e aqui foi usado fmt.Sprintf()?
rdurl0
approved these changes
Feb 25, 2025
| - cron: "0 3 * * 2,4" | ||
| workflow_dispatch: | ||
| # schedule: | ||
| # - cron: "0 3 * * 2,4" |
There was a problem hiding this comment.
Só confirmando: essas linhas ficam comentadas até a definição da política de deploy/manutenção/revisão, né?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.