perf: use new jpeg2000 codec to enhance memory performance #51
+208
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Original codec will allocate about 400mb of memory - New version is about 70mb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this pull request is trying to achieve
Use new jpeg2000 codec from cornerstone to enhace mermory usage
Additional notes and description of your changes
decodeAsyncbecoming async function may cause issue with loading image before codec has finished loadingEnvironment this was tested in
OS: Windows 11 24H2
Browser: 132.0.6834.197
Test Details
Original
https://cylab-tw.github.io/bluelight/bluelight/html/start.htmland load jpeg2000 image (size is 90kb)Modified version of PR
https://cylab-tw.github.io/bluelight/bluelight/html/start.htmland load jpeg2000 image (size is 90kb)