fix(wado-rs): can not decode some multipart properly #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this pull request is trying to achieve
wadorsloader
not decode some multipart response properlyAdditional notes and description of your changes
In this code snippet, it try to convert all buffer to string, as may exceeds max string length when encountering large data.
bluelight/bluelight/scripts/viewer.js
Lines 124 to 127 in 5c90ef4
Here, acceptable headers are hardcode, and rereturing headers that are legal (e.g.
Content-Location
) will result in decoding failurebluelight/bluelight/scripts/viewer.js
Lines 138 to 152 in 5c90ef4
Use
multipartDecode
from dcmjs and it work properlyEnvironment this was tested in
Test Details
serve
to host bluelight in local/bluelight/html/start?StudyInstanceUID=1.3.6.1.4.1.14519.5.2.1.1869.4002.216192212057343433620283048159
Related Issues