Added: AzureRM implementation #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can avoid some configurations that are not standard for what we accept
For now just virtual_machine and linux_virtual_machine
So we can mock the API calls
So it's also part of the standard parsing
xlr-8
suggested changes
Dec 10, 2021
e2e/azurerm_ingestion_test.go
Outdated
|
|
||
| allProds, err := backend.Products().Filter(ctx, &product.Filter{Provider: util.StringPtr(azurerm.ProviderName), Service: util.StringPtr(azurerm.VirtualMachines.String())}) | ||
| require.NoError(t, err) | ||
| fmt.Println(len(allProds)) |
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I didn't see any sensitive data, I assume it got cleaned up? Asking just to double check
testdata/azurerm/stack-compute/vm.tf
Outdated
Comment on lines
180
to
219
| ### Extra resources to add if needed! | ||
|
|
||
| ## 1 - Attach extra storage to the VM | ||
| ## Please copy the next section of code into a separate .tf file in the config branch of your stack | ||
| ## NOTE! Check the comments to know more about the available options | ||
|
|
||
| # a) Creates an extra volume | ||
| #resource "azurerm_managed_disk" "extra" { | ||
| # name = "${var.customer}-${var.project}-${var.env}-extra-disk" | ||
| # location = var.azure_location | ||
| # resource_group_name = module.vm.resource_group_name | ||
| # storage_account_type = "Standard_LRS" # Available options: Standard_LRS, StandardSSD_ZRS, Premium_LRS, Premium_ZRS, StandardSSD_LRS or UltraSSD_LRS | ||
| # create_option = "Empty" # Available options: "Import", "Empty", "Copy", "FromImage", "Restore" | ||
| # ##image_reference_id = ... # (Optional) ID of an existing platform/marketplace disk image to copy when create_option is FromImage | ||
| # disk_size_gb = 5 # in Gb | ||
| #} | ||
| ## b) Attaches it to the instance created | ||
| #resource "azurerm_virtual_machine_data_disk_attachment" "vm_attach" { | ||
| # managed_disk_id = azurerm_managed_disk.extra.id | ||
| # virtual_machine_id = azurerm_virtual_machine.example.id | ||
| # lun = "10" # (Required) - The Logical Unit Number of the Data Disk, which needs to be unique within the Virtual Machine. | ||
| # caching = "ReadWrite" # Available options: "None", "ReadOnly" and "ReadWrite" | ||
| #} | ||
|
|
||
| ## 2 - Add more network security rules | ||
| ## Please copy the next section of code into a separate .tf file in the config branch of your stack | ||
| ## NOTE! Check the comments to know more about the available options | ||
| #resource "azurerm_network_security_rule" "extra_rule" { | ||
| # name = "extra_rule" | ||
| # priority = 100 # Value : [100-4096] | ||
| # direction = "Outbound" | ||
| # access = "Allow" | ||
| # protocol = "Tcp" # Possible values: "Tcp", "Udp", "Icmp", "Esp", "Ah" or "*" | ||
| # source_port_range = "*" | ||
| # destination_port_range = "*" | ||
| # source_address_prefix = "*" | ||
| # destination_address_prefix = "*" | ||
| # resource_group_name = module.vm.resource_group_name | ||
| # network_security_group_name = module.vm.network_security_group_name | ||
| #} |
There was a problem hiding this comment.
Seems like it can be removed
|
Done :) |
Also fixed some google things and added the testdata from AZ
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just supporting
virtual_machine(linux) andlinux_virtual_machinewith thesize.Related #3