542 write external storage deprecated #543
Conversation
…gher. Remove @RequiresApi = M as minSDK is now 23 (=M).
… as this can be handled by the camera app. Change READ_EXTERNAL_STORAGE to READ_MEDIA_IMAGE for Android 13 upwards.
|
Thanks for looking at this, Hilary. I'll leave others to review but it's great to see this being addressed. |
|
@jezhiggins @oliverlockwood Could one of you kindly review this? Seems this will also partly deal with #544. |
|
Thanks for the review :) Are we able to roll a release? Another report about missing map tiles recently. |
|
Now this has been merged, the beta release should go out automatically and chances are people will have it by the morning. Assuming that looks ok, we can promote it to a regular release in the next few days. |
|
Awesome, thanks all. Will look forward to the release notes appearing. |
|
I don't think this has made it to the Play Store yet. I tried re-installing from there but the issue is still occurring. |
|
Yes, I noticed this myself this morning. Going to have a look around this evening or tomorrow. (It's entirely possible there's something I need to do but have forgotten) On 3 Feb 2024 09:30, HilaryN ***@***.***> wrote:
I don't think this has made it to the Play Store yet. I tried re-installing from there but the issue is still occurring.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Something up with Travis - it's stopped building because some kind of problem with our plan. We're on their open source software plan so not sure what's going on, hopefully just a cock up. I've emailed support, they were very quick to respond last time so fingers crossed. |
|
FYI, this happened to the OSS repos we (mostly I) maintain at my employer, too. Travis seems to be gradually making more and more hoops for OSS to jump through, it seems as though in their push to become profitable they're trying to discourage OSS usage while still claiming they support it for free. I've migrated those to Github Actions, it wasn't too tough and I have a reference point there (though admittedly not for an Android build). I'll take an action to look into doing likewise for the CycleStreets CI at some point. |
|
See e.g. (partly for my own reference): |
|
Travis have done whatever the need to do, and the build is running again for now. Beta has been pushed up to Google Play so hopefully will make it's way out this evening |
To fix #542
I haven't touched the READ permission request in MapPack as I think that isn't working at the moment?
Write permissions for app-specific storage (i.e. map tiles) is no longer required. Same for Read permission for app-specific storage (which doesn't seem to get explicitly requested, presumably as it's granted as part of the write permission). Removed for Android 13 upwards. (CycleMapFragment)
Note that because permission for map tiles is no longer granted, the old cache location won't get removed – I'm not sure if this is an issue? (See CycleMapFragment.onRequestPermissionsResult)
CycleMapView – I've just changed the log message in here.
Write permission to store photos should be handled by the camera app – removed for Android 13 upwards. (AddPhotoFragment)
Read permission to access photos - changed to READ_MEDIA_IMAGES for Android 13 upwards.
Tested on Pixel 3 API 28 (Android 9) emulator, Fairphone 2 (Android 10), Fairphone 3 (Android 13).