refactor: use helper function to detect ramp #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertoCentonze
force-pushed
the
refactor-ramping-check
branch
from
fb1b9bb to
71b3a46
Compare
heswithme
reviewed
Feb 19, 2025
improved some comments for clarity along the way
AlbertoCentonze
force-pushed
the
refactor-ramping-check
branch
from
71b3a46 to
c291507
Compare
heswithme
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactor that greatly improves readability at the cost of efficiency. The gas overhead will be removed once this PR gets merged and we start using venom (there is ongoing research with the hevm team to formally verify soundness of optimizations).