Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archetype] Replace JUnit Jupiter with AssertJ #2969

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

mpkorstanje
Copy link
Contributor

⚡️ What's your motivation?

As a JUnit Platform Engine, Cucumber does not need JUnit Jupiter. It was included as a dependency to allow users to use Assertions. This is better done with AssertJ.

🏷️ What kind of change is this?

  • 📖 Documentation (improvements without changing code)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

As a JUnit Platform Engine, Cucumber does not need JUnit Jupiter. It was
included as a dependency to allow users to use Assertions. This is
better done with AssertJ.
@mpkorstanje mpkorstanje force-pushed the replace-jupiter-with-assertj branch from ca68ac4 to 90fcd1a Compare January 31, 2025 16:56
@mpkorstanje mpkorstanje merged commit fc5956b into main Feb 2, 2025
6 checks passed
@mpkorstanje mpkorstanje deleted the replace-jupiter-with-assertj branch February 2, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant