Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(schema-compiler): Use member expression definition as measure key #9154

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Draft

[WIP] fix(schema-compiler): Use member expression definition as measure key #9154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[WIP][add test] fix(schema-compiler): Use member expression definitio… 
…n as measure key

Without this when measure was a member expression m.measure.name can be undefined, and different measures will have same key in collectRootMeasureToHieararchy
@mcheshkov
mcheshkov committed Jan 29, 2025
commit 64a90c5129de300ff93940b42f645b2e5b970362
12 changes: 11 additions & 1 deletion packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
View file
Original file line number Diff line number Diff line change
@@ -1574,7 +1574,17 @@ export class BaseQuery {
const cubeName = m.expressionCubeName ? `\`${m.expressionCubeName}\` ` : '';
throw new UserError(`The query contains \`COUNT(*)\` expression but cube/view ${cubeName}is missing \`count\` measure`);
}
return [typeof m.measure === 'string' ? m.measure : `${m.measure.cubeName}.${m.measure.name}`, collectedMeasures];

let measureKey;
if (typeof m.measure === 'string') {
measureKey = m.measure;
} else if (m.isMemberExpression) {
// TODO expressionName vs definition?
measureKey = m.expressionName;
} else {
measureKey = `${m.measure.cubeName}.${m.measure.name}`;
}
return [measureKey, collectedMeasures];
}));
}

Loading