Correct dremio date interval functions

[wardsi]

Check List

• Tests have been run in packages where changes made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

Issue Reference this PR resolves
In the dremio driver (query) the syntax for DATE_ADD and DATE_SUB are incorrect. The interval function requires a cast and the positional arguments need correcting.

[KSDaemon]

Unfortunately, intervals are a bit more complicated. You can get here interval values like:

• 1 hour 2 minutes
• 3 month
• 3 months 24 days 15 minutes
• 2 years 6 months
• Etc....

Please, have a look at some examples of interval processing in different dialects that might give you an idea how to process it here:

• cube/packages/cubejs-schema-compiler/src/adapter/MysqlQuery.ts

  Line 62 in bb86016

  public subtractInterval(date: string, interval: string) {

• https://github.com/cube-js/cube/blob/master/packages/cubejs-schema-compiler/src/adapter/BigqueryQuery.ts#L180
• https://github.com/cube-js/cube/blob/master/packages/cubejs-schema-compiler/src/adapter/ClickHouseQuery.ts#L84

Have a look at formatInterval() implementations in these query dialects.
Hope this helps!

[wardsi]

Many thanks for the info. I have sent a further change. It only supports year,qtr,month and day for now. I've taken examples from the other drivers as per suggestions above.

[KSDaemon]

Looking at the docs, I see that Dremio supports more intervals for timestamps.

DATE_ADD(timestamp_expression string, time_interval interval) → timestamp
timestamp_expression: A string-formatted timestamp in the format 'YYYY-MM-DD HH24:MI:SS'.
time_interval: A CAST of a number to one of these intervals: SECOND, MINUTE, HOUR, DAY, MONTH, YEAR.

So i think they should be supported here too :)

[wardsi]

Agreed, we also need to support a week method as well in the same way the quarter is calculated.

[KSDaemon]

Please add support for SECOND, MINUTE, HOUR

[KSDaemon]

There are these functions defined in base class that you can override:

  /**
   * @param {string} timestamp
   * @param {string} interval
   * @returns {string}
   */
  addTimestampInterval(timestamp, interval) {
    return this.addInterval(timestamp, interval);
  }

  /**
   * @param {string} timestamp
   * @param {string} interval
   * @returns {string}
   */
  subtractTimestampInterval(timestamp, interval) {
    return this.subtractInterval(timestamp, interval);
  }

[KSDaemon]

Another thing I missed: you should also provide the template for INTERVAL that might be used by SQL API.
Have a look at sqlTemplates() function in other Query classes as example (PostgresQuery, BigqueryQuery, etc):

    templates.expressions.interval = 'INTERVAL \'{{ interval }}\'';