Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CW2-24 Setup Backend #12

Merged
merged 47 commits into from
Jun 4, 2024
Merged

CW2-24 Setup Backend #12

merged 47 commits into from
Jun 4, 2024

Conversation

PenTest-duck
Copy link
Collaborator

@PenTest-duck PenTest-duck commented May 30, 2024

Significant change to the fundamental structure of the repo - adding in the Express backend.
Now the structure of the repo is a monorepo, with docker-compose.yml in the base directory, and subdirectories for /frontend and /backend.

  • Implemented Dockerfiles for each frontend (port 3000) & backend (port 9000) services + Docker Compose to spin them both up
  • Set up Express server with Routes + Controllers
    • Created /ping endpoint to verify connection
    • Created mock button in frontend to trigger ping
  • Extended Github actions to include CI (type checking & building) for backend
Screenshot 2024-05-30 at 7 38 15 PM

jamest0 and others added 30 commits September 10, 2023 22:52
* Add formatting and linting

* Add github workflow
* added events template

* removed section

* modified events to coordinate with navbar on click

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>
* changed the h1 tags

* changed image alt tags

* changed tailwind

* CW2-3 Add events section (#4)

* added events template

* removed section

* modified events to coordinate with navbar on click

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>

* changes to make linter approve

* formatted code?

---------

Co-authored-by: Stuart Cutbush <[email protected]>
Co-authored-by: Derek Xu <[email protected]>

export default function EventsPage() {
const pingBackend = async () => {
axios
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't intend to make this the norm for calling APIs - this was just for MVP
Later I will abstractify the API calling logic in a "middleware" per se

@PenTest-duck PenTest-duck self-assigned this May 30, 2024
@PenTest-duck PenTest-duck requested a review from derekxu04 May 30, 2024 09:35
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't intend to keep this in the repo for long - again, just for MVP

@PenTest-duck PenTest-duck changed the title CW2-24 [DRAFT] setup backend CW2-24 Setup Backend May 30, 2024
Copy link
Collaborator

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I've rewritten the README.md in line with the new changes, feel free to have a quick look and see if there is anything you would like to add / change.

Otherwise, happy to merge

@PenTest-duck PenTest-duck merged commit 16ad1ca into master Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants