Allow SegmentedControl translate titles on the fly
#720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philemon Ukane <[email protected]>
ukane-philemon
commented
Jan 30, 2025
Comment on lines
169
to
+170
| func (dst *destination) isSendToAddress() bool { | ||
| return dst.accountSwitch.SelectedSegment() == values.String(values.StrAddress) | ||
| return dst.accountSwitch.SelectedSegment() == values.StrAddress |
There was a problem hiding this comment.
This is one case where the formal approach caused the send page to not function properly due to an incorrect equality check.
SelectedSegment() was returning a pre-translated string(english) and values.String(values.StrAddress) was returning the current string translation(e.g french) after a language change.
dreacot
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the required segmented titles from pre-translated to the translation key to allow SegmntedControl to translate on the fly and be able to handle cases where language change might result to incorrect segmented title equality checks.
SegmentedControl.SetSelectedSegmentnow accepts an actual translation key instead of a pre-translated string andSegmentedContol.SelectedSegmentreturns the same.