Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-5595: Modularize the scaffolds - Django Scaffold #248

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

santoshpy
Copy link
Contributor

@santoshpy santoshpy commented Aug 30, 2021

Ticket

PLAT-5595
Related tickets: PLAT-5595
Related PRs:

Type of PR

  • Bugfix
  • New feature
  • Minor changes

Changes introduced

Manage the folder structure for the backend.
Update README.md file for consistency

Test and review

AS this PR is related to PLATFORM-DASHBOARD to test it, Need to merge all related PR.

@santoshpy santoshpy changed the title Plat 5595 PLAT-5595: Modularize the scaffolds - Django Scaffold Aug 30, 2021
@santoshpy santoshpy marked this pull request as ready for review August 31, 2021 15:08
Copy link
Contributor

@danielsousaio danielsousaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file .github/dependabot.yml shares the same path in both this scaffold and crowdbotics/modules, how will this work? Will the last to be cookiecut overwrite the previous?

We should instead have a base shared dependabot.yml, perhaps.

Same concern applies for .gitignore, and .gitattributes.

@santoshpy
Copy link
Contributor Author

santoshpy commented Sep 6, 2021

The file .github/dependabot.yml shares the same path in both this scaffold and crowdbotics/modules, how will this work? Will the last to be cookiecut overwrite the previous?

We should instead have a base shared dependabot.yml, perhaps.

Same concern applies for .gitignore, and .gitattributes.

For .github/dependabot.yml mobile app scaffold will overwrite this

For .gitignore and .gitattributes will discuss with Dan.

@driverdan driverdan changed the base branch from develop to master October 15, 2021 17:53
@driverdan
Copy link
Collaborator

@santoshpy For the git files, can we merge them from the scaffolds and make them identical? It shouldn't hurt to have them include paths from both backend and frontend.

mabdullahabid
mabdullahabid previously approved these changes Dec 14, 2021
Copy link
Contributor

@mabdullahabid mabdullahabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder structure change looks okay to me. It'll be more maintainable if we can make the changes that @danielsousaio and @driverdan recommended. It should still work without them though.

@driverdan
Copy link
Collaborator

@santoshpy Can you fix the merge conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants