-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAT-5595: Modularize the scaffolds - Django Scaffold #248
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file .github/dependabot.yml
shares the same path in both this scaffold and crowdbotics/modules, how will this work? Will the last to be cookiecut overwrite the previous?
We should instead have a base shared dependabot.yml
, perhaps.
Same concern applies for .gitignore
, and .gitattributes
.
For For |
@santoshpy For the git files, can we merge them from the scaffolds and make them identical? It shouldn't hurt to have them include paths from both backend and frontend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folder structure change looks okay to me. It'll be more maintainable if we can make the changes that @danielsousaio and @driverdan recommended. It should still work without them though.
@santoshpy Can you fix the merge conflicts? |
Ticket
PLAT-5595
Related tickets: PLAT-5595
Related PRs:
Type of PR
Changes introduced
Manage the folder structure for the backend.
Update README.md file for consistency
Test and review
AS this PR is related to PLATFORM-DASHBOARD to test it, Need to merge all related PR.