Actually enable debug logs if requested #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if requested I noticed that when enabling debug logs, the level doesn't actually get set. This should fix that. Signed-off-by: Wim Fournier <[email protected]>
|
Not sure why the DCO is failing here.. |
negz
reviewed
Jan 8, 2025
| @@ -75,7 +75,7 @@ def dropper(logger, method_name, event_dict): # noqa: ARG001 # We need this si | |||
| structlog.processors.EventRenamer(to="msg"), | |||
| structlog.processors.JSONRenderer(), | |||
| ], | |||
| wrapper_class=structlog.make_filtering_bound_logger(logging.INFO), | |||
| wrapper_class=structlog.make_filtering_bound_logger(logging.DEBUG if level == Level.DEBUG else logging.INFO), | |||
There was a problem hiding this comment.
It should never reach here if level == Level.DEBUG, right? See lines 59-67 above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when enabling debug logs, the level doesn't actually get set. This should fix that.
Description of your changes
Fixes #
I have: