Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how to skip empty notifications using templates #1841

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

simskij
Copy link
Member

@simskij simskij commented Nov 12, 2023

resolves #1200

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a047c7f) 70.55% compared to head (507528b) 70.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1841   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files          26       26           
  Lines        2493     2493           
=======================================
  Hits         1759     1759           
  Misses        633      633           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simskij simskij merged commit cfc00ee into main Nov 12, 2023
12 checks passed
@simskij simskij deleted the fix/docs-for-empty-notifications branch November 12, 2023 12:46
@piksel
Copy link
Member

piksel commented Nov 12, 2023

Hm, but that isn't entirely correct as it only applies to non-report templates.

(and the sentence before it only applies to report templates).

The difference being that the non-report templates only has a list of log messages as it's data.

@simskij simskij mentioned this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to avoid empty notifications when using notification templates
2 participants