Enable debugger for tests on macOS #446
Conversation
Tests that are currently on the main branch only runs against a qemu VM. We have other use cases that needs to be tested like running against a vfkit VM. This commit reorganizes the tests code a bit by moving the files that can be shared to support different implementation in their own folder. The reasoning behind this is that every hypervisor should have its own beforeSuite func to download/run a specific VM image. By moving the utils files we can reuse the same code. For the same reason the code targeting qemu is moved to the test-qemu folder. By doing so, we can run the tests within the test-qemu folder on the ubuntu workflow and, in future, when the nested virt will be enabled on github runners, the vfkit tests on macOS. Signed-off-by: Luca Stocchi <[email protected]>
Adds a basic implementation for testing against a vfkit VM. Tests are based on the existing qemu version. It just changes the way the VM gets created/started. Signed-off-by: Luca Stocchi <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.29.0 to 0.31.0. - [Commits](golang/crypto@v0.29.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: evidolob The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| ``` | ||
| This command will run build `gvisor` binary with debugger enabled. | ||
|
|
||
| >Note: By default it would use `--continue` `dlv` option to not pause `givisor` execution on start, if debugger is not connected. |
There was a problem hiding this comment.
givisor typo (extra i). What do you mean by gvisor though? Is it gvproxy, or is it any program using gvisor-tap-vsock as a package?
| >Note: By default it would use `--continue` `dlv` option to not pause `givisor` execution on start, if debugger is not connected. | ||
| > To pause `gvisor` execution until debugger is connected just remove `"--continue"` parameter from this [line](./test-vfkit/vfkit_suite_test.go#L93) | ||
|
|
||
| And debug sever with `2345` port, you could use any `delve` client to interact with debugger |
There was a problem hiding this comment.
sever typo (->server). It occurs a few times in this file.
This PR depends on #427
For example of usage look on "DEVELOPMENT.md"