Manually add OTEL context to both root spans #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
otel-ctx
branch
from
63c0164 to
bb2a9b5
Compare
According to open-telemetry/opentelemetry-rust#888 (comment), this works around the issue where the root span is missing from the traces. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
otel-ctx
branch
from
bb2a9b5 to
9240f2f
Compare
saschagrunert
commented
Oct 17, 2022
| @@ -312,7 +312,7 @@ var _ = Describe("ConmonClient", func() { | |||
| rssAfter := vmRSSGivenPID(pid) | |||
| GinkgoWriter.Printf("VmRSS after: %d\n", rssAfter) | |||
| GinkgoWriter.Printf("VmRSS diff: %d\n", rssAfter-rssBefore) | |||
| Expect(rssAfter - rssBefore).To(BeNumerically("<", 1200)) | |||
| Expect(rssAfter - rssBefore).To(BeNumerically("<", 1500)) | |||
There was a problem hiding this comment.
The integration tests seemed to flake more lately. Not really related to this PR, but should make them more resilient.
|
/lgtm |
|
Tide seems to not react on the state of this PR 🤔 |
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
According to open-telemetry/opentelemetry-rust#888 (comment), this works around the issue where the root span is missing from the traces.
Which issue(s) this PR fixes:
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?