Add configurability to Netavark firewall driver

[cgiradkar]

closes #1338

[Luap99]

You also have to add this new field to docs/containers.conf.5.md to documented it in the man page.

[Luap99]

You still have to document the field under docs/containers.conf.5.md

[Luap99]

Suggested change

	# The default firewall driver to be used
	# firewall_driver = "iptables"
	# The firewall driver to be used by netavark.
	# The default is empty which means netavark will pick one accordingly. Current supported
	# drivers are "iptables", "none" (no firewall rules will be created) and "firewalld" (firewalld is
	# experimental at the moment and not recommend outside of testing). In the future we are
	# planning to add support for a "nftables" driver.
	#firewall_driver = ""

As text for the documentation. @mheon WDYT?

[mheon]

Should mention that the default is iptables - maybe "Netavark will use the default (iptables)" instead of "netavark will pick one accordingly"

[Luap99]

Yeah I was thinking about it but then I remembered that we do not really control what nv version is on the system and if we decide to flip the default to nftables once it is ready I would assume that we forget to update the page here.

[mheon]

Fair enough. We might also add some sort of autodetection for systems without iptables but with nft at some point as well, which would affect the default.

[rhatdan]

@cgiradkar is this still a draft?

[rhatdan]

@mheon @Luap99 PTAL

[mheon]

LGTM

[Luap99]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgiradkar, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment