optimize gas usage with common techniques and refactor code structure #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
NIC619
reviewed
Feb 5, 2025
| assembly { | ||
| // Compute the digest. | ||
| mstore(0x00, 0x1901000000000000000000000000000000000000000000000000000000000000) // Store "\x19\x01". | ||
| mstore(0x2, digest) // Store the domain separator. |
There was a problem hiding this comment.
Maybe align with other hex values:
Suggested change
| mstore(0x2, digest) // Store the domain separator. | |
| mstore(0x02, digest) // Store the domain separator. |
| digest = _getDomainSeparator(); | ||
|
|
||
| // solhint-disable no-inline-assembly | ||
| assembly { |
There was a problem hiding this comment.
Are those inline assemblies copied from some standard library? How much gas does it save?
There was a problem hiding this comment.
Is it possible to use OZ's 712 implementation?
| @@ -45,6 +45,7 @@ contract SignatureValidatorTest is Test { | |||
| assertFalse(SignatureValidator.validateSignature(vm.addr(walletAdminPrivateKey), otherDigest, signature)); | |||
| } | |||
|
|
|||
| /// forge-config: default.allow_internal_expect_revert = true | |||
There was a problem hiding this comment.
What is the setting for? Where is it checked?
| bytes memory strategyData = abi.encode(UNISWAP_SWAP_ROUTER_02_ADDRESS, makerSpecificData); | ||
| bytes memory strategyData = abi.encode(UNISWAP_SWAP_ROUTER_02_ADDRESS, order.makerToken, order.makerTokenAmount - fee, makerSpecificData); |
There was a problem hiding this comment.
Why added these two parameters? Is it because the change of executeStrategy interface?
|
Can you still run |
Yes, it works fine after enabling the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
via-irsetting.optimizer_runsfrom 1,000 to 65,536.executeStrategyfunction.getEIP712Hashfunction of EIP-712 using assembly code.