Improve EAR policy #640
Merged
Improve EAR policy #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SNP executables should depend on the SNP reference values Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Make the policy logic simpler. Rather than using the min function (which I'm not sure is even defined on TrustClaims) use short-circuiting to only evaluate the rules for the platform that has TCB values defined. I don't think there is any risk that the policy could be tricked into evaluating the wrong rules, such as the sample ones. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Xynnn007
approved these changes
Jan 2, 2025
This policy is still intended to be used with all the platforms we support. Previously I defined intermediate claims such as We do still have TODOs at the bottom to add logic for other platforms. I am hoping that all our platforms will be defined here soon but I may need a bit of help with that from platform experts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to set claims for every platform and compare them with min. We can just set the claims directly and rely on short-circuiting to skip any platforms that don't have TCB claims set.