config: fix custom pccs deployment for TDX #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently split the nodeport yaml into an s390x and an x86_64 directory, but we forgot to update the custom_pccs yaml to point to the correct one. For now let's assume that the custom_pccs will always run on x86_64 since it's for TDX. We might revisit that assumption in the future. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Maybe we don't even need the nodeport manifests in per-arch overlays as it should be arch-agnostic. Anyway, this is a topic for another PR maybe :) |
wainersm
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently split the nodeport yaml into an s390x
and an x86_64 directory, but we forgot to update
the custom_pccs yaml to point to the correct one.
For now let's assume that the custom_pccs will
always run on x86_64 since it's for TDX.
We might revisit that assumption in the future.