Add failure count track to Mill's execution and logging #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a mechanism to track and display the number of failed tasks during Mill's execution: Added failureCount atomic integer in Execution to track task failures Updated PrefixLogger to support displaying failure count in the prompt header Implemented logic to increment failure count when tasks fail Added comprehensive test cases in PromptLoggerTests to verify failure count behavior The new feature provides more visibility into task execution by showing the number of failed tasks in the build output.Please open all PRs as drafts and ensure that your fork of Mill has settings/actions / Allow all actions and reusable workflows enabled to run CI on your own fork of the Mill repo. Only once CI passes mark the PR as Ready for review and CI will run on the main Mill repo before we merge it.
zelosleone
changed the title
|
@lihaoyi ready for review. |
|
This doesn't seem to work 
Please add a test case to |
This commit improves Mill's build failure reporting by: - Adding failure count tracking to task execution in `Execution` - Preserving header prefix when updating failure count in `PrefixLogger` - Adding comprehensive integration tests for failure tracking across different build scenarios - Ensuring consistent and informative failure reporting in interactive, CI, and multi-threaded environments
This commit improves Mill's logging and failure tracking by: - Centralizing failure count tracking in the Execution class - Simplifying PrefixLogger's logging and failure count handling - Enhancing PromptLogger to better display failure information - Updating PromptLoggerUtil to render headers with failure counts - Improving log message formatting and prefix handling
…o failurecount
lihaoyi
reviewed
Feb 21, 2025
| @@ -74,5 +73,467 @@ object FullRunLogsTests extends UtestIntegrationTestSuite { | |||
| assert(millProfile.exists(_.obj("label").str == "show")) | |||
| assert(millChromeProfile.exists(_.obj("name").str == "show")) | |||
| } | |||
| test("compilation-error") - integrationTest { tester => | |||
There was a problem hiding this comment.
This test cases is pretty unreadable and there isn't really any chance we'll be able to maintain it going forward. Please follow the style of the test cases above
There was a problem hiding this comment.
Yeah no worries, I found the reason of this and will be rewriting it soon.
|
I will open a new PR to solve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a mechanism to track and display the number of failed tasks during Mill's execution:
Added failureCount atomic integer in Execution to track task failures Updated PrefixLogger to support displaying failure count in the prompt header Implemented logic to increment failure count when tasks fail Added comprehensive test cases in PromptLoggerTests to verify failure count behavior The new feature provides more visibility into task execution by showing the number of failed tasks in the build output.Please open all PRs as drafts and ensure that your fork of Mill has settings/actions / Allow all actions and reusable workflows enabled to run CI on your own fork of the Mill repo. Only once CI passes mark the PR as Ready for review and CI will run on the main Mill repo before we merge it.
Solves #4588