Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coursier to 2.1.25-M2 (adds early Gradle Module support) #4591

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexarchambault
Copy link
Collaborator

No description provided.

@alexarchambault alexarchambault marked this pull request as ready for review February 20, 2025 10:36
@alexarchambault
Copy link
Collaborator Author

alexarchambault commented Feb 20, 2025

I don't like the new error message when the version is empty (No version available in (,), while it was something like this before: not found: https://repo1.maven.org/maven2/com/google/protobuf/protobuf-java//protobuf-java-.pom). Going to try to fix that before coursier 2.1.25 final. But we could merge to try the Gradle Module stuff.

@lihaoyi
Copy link
Member

lihaoyi commented Feb 21, 2025

Looks good to me, I assume usage of the gradle module support will come in follow ups, but feel free to merge this first if you would like

lihaoyi
lihaoyi approved these changes Feb 21, 2025
 Conflicts:
	contrib/bloop/src/mill/contrib/bloop/BloopImpl.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants