Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init for sbt #4575

Closed
wants to merge 5 commits into from
Closed

Add init for sbt #4575

wants to merge 5 commits into from

Conversation

sake92
Copy link
Contributor

@sake92 sake92 commented Feb 17, 2025

Got basic init setup for sbt working.

Depends on https://github.com/[sake92/sbt-build-extract](https://github.com/sake92/sbt-build-extract) sbt plugin.
Users have to add it to their plugins.sbt file.
The plugin exports each sbt project to root target/build-export folder, in JSON format.

Then mill picks up those JSON files and parses them to build the build.mill and package.mill files.

@lihaoyi
Copy link
Member

lihaoyi commented Feb 18, 2025

The approach of using a custom SBT plugin sounds reasonable. Can we include it in this PR and keep it in the Mill repo?

Adding the plugin manually seems like it can be automated by having the command write a file project/mill_export.sbt to include it during the export, and remove the file after it's done

@sake92
Copy link
Contributor Author

sake92 commented Feb 18, 2025

I've embedded it inside this repo:

  • added CI to run on PR
  • added CD to publish on tag

Also applied project/exportBuildStructure.sbt temporarily as you suggested, works good!

@sake92
Copy link
Contributor Author

sake92 commented Feb 25, 2025

Seems like I didnt copy the sbt plugin sources properly 🤦🏻

But anyways, seems like #4586 got it further.

@sake92 sake92 closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants