Refined rotation averaging #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lpanaf
commented
Jul 28, 2024
lpanaf
commented
- Initialization from MST
- Gravity-aligned rotation averaging
ahojnnes
reviewed
Jul 29, 2024
|
|
||
| // Unique identifier for images. | ||
| typedef uint32_t image_t; | ||
| using colmap::image_t; | ||
|
|
||
| // Each image pair gets a unique ID, see `Database::ImagePairToPairId`. | ||
| typedef uint64_t image_pair_t; |
ahojnnes
reviewed
Jul 29, 2024
glomap/math/tree.cc
Outdated
Comment on lines
82
to
83
| std::unordered_map<image_t, int> image_id_to_idx; | ||
| std::unordered_map<int, image_t> idx_to_image_id; |
There was a problem hiding this comment.
Suggested change
| std::unordered_map<image_t, int> image_id_to_idx; | |
| std::unordered_map<int, image_t> idx_to_image_id; | |
| std::unordered_map<image_t, int> image_id_to_idx; | |
| image_id_to_idx.reserve(images.size()); | |
| std::unordered_map<int, image_t> idx_to_image_id; | |
| idx_to_image_id.reserve(images.size()); |
|
Maybe run a clang_fromat before merging. |
ahojnnes
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.