Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine mapper options and add documentations #11

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Refine mapper options and add documentations #11

merged 4 commits into from
Jul 31, 2024

Conversation

lpanaf
Copy link
Collaborator

@lpanaf lpanaf commented Jul 31, 2024

No description provided.

@lpanaf lpanaf enabled auto-merge (squash) July 31, 2024 10:14
@lpanaf lpanaf disabled auto-merge July 31, 2024 10:14
@lpanaf lpanaf requested a review from ahojnnes July 31, 2024 10:14
@lpanaf lpanaf enabled auto-merge (squash) July 31, 2024 10:27
@lpanaf lpanaf changed the title Add more options to mapper Refine mapper options and add documentations Jul 31, 2024
@@ -1,6 +1,6 @@
# GLOMAP: Global Structure-from-Motion Revisited
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we refer to the getting_started doc in the README?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

@@ -0,0 +1,20 @@
# Getting started
### Installation and End-to-End Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ## instead of ### here and for other headings below?

@lpanaf lpanaf merged commit 816e06f into main Jul 31, 2024
4 checks passed
@lpanaf lpanaf deleted the more_options branch August 2, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants