mock: Switch out xml-builder with quick-xml #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ColinKinloch
force-pushed
the
quick_xml_writer
branch
from
ba205a8 to
2677444
Compare
ColinKinloch
force-pushed
the
quick_xml_writer
branch
from
2677444 to
1fdd7e8
Compare
em-
reviewed
Feb 7, 2025
| @@ -102,8 +101,7 @@ impl Respond for ProjectBuildCommandResponder { | |||
| // error is wrapped *as a string* inside of a different | |||
| // error. Mimic the behavior here. | |||
| let inner_xml = unknown_package(package_name.to_owned()).into_xml(); | |||
| let mut inner = Vec::new(); | |||
| inner_xml.render(&mut inner, false, true).unwrap(); | |||
| let inner = inner_xml.into_inner().into_inner(); | |||
There was a problem hiding this comment.
Just checking: is the double into_inner() needed?
There was a problem hiding this comment.
Yes: quick_xml::Writer<Cursor<Vec<u8>>> -> Cursor<Vec<u8>> -> Vec<u8>.
em-
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week
xml-builderwent from0.5.3to0.5.4making API changes which stopped CI from passing.On crates.io
xml-builderhas 7 dependents vsquick-xmls 650.This currently passes
cargo test, however more should probably be done to verify this change doesn't produce different XML.This MR is on top of #19