Make UploadableFile::get_data async for AsyncRead #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been attempting to bump the version of this in
obs-gitlab-runner
from0.5.0
to0.8.0
.It currently stores a map of path strings to
tokio::File
s for artifacts, but I've changed it to use aVec<UploadableFile>
.My current implementation does this:
I didn't make
get_path
async as it is used in a non async context and I'm not sure it's necessary.