feat: Add Popover UI primitive #1849
Open
+460
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
force-pushed
the
paul/add-popover-primitive
branch
from
03f42a1 to
fa0cf6e
Compare
cpcramer
commented
Jan 22, 2025
| /** | ||
| * Calculates the initial position of the popover based on the position prop. | ||
| */ | ||
| function getInitialPosition( |
There was a problem hiding this comment.
I don't see these functions being reused so i've left them in the Popover file
cpcramer
force-pushed
the
paul/add-popover-primitive
branch
from
99bf90e to
0de6048
Compare
cpcramer
force-pushed
the
paul/add-popover-primitive
branch
from
cd3a1fa to
009edc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Add Popover UI Primitive.
This primitive handles positioning relative to an anchor / trigger element, focus management, click outside and escape key dismissal, portal rendering, and proper ARIA attributes.
Notes to reviewers
How has it been tested?
Tested with SwapSettings component - PR implementation to follow.
Tested updates to DismissableLayer, WalletModal still works as expected.