Chore: WalletIsland Code Quality Fast Follows #1842

brendan-defi · 2025-01-19T23:18:43Z

What changed? Why?

WalletComponents pull address from context by default, only wagmi if intended to be used outside of WalletProvider
remove cursor state management, use pure css
refactor draggable repositioning, including preventing dragging offscreen
remove unused svg
extract copyToClipboard to an internal util

Notes to reviewers

How has it been tested?

vercel · 2025-01-19T23:19:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
onchainkit-coverage	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 5:50pm
onchainkit-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 5:50pm
onchainkit-routes	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 22, 2025 5:50pm

src/internal/components/Draggable/getDefaultStartingPosition.ts

src/internal/components/Draggable/useBoundedPosition.ts

src/core/utils/copyToClipboard.ts

src/internal/components/Draggable/useBoundedPosition.ts

src/internal/components/Draggable/Draggable.tsx

src/internal/components/CopyButton.tsx

github-actions bot added the pkg: wallet label Jan 19, 2025

vercel bot deployed to Preview – onchainkit-playground January 19, 2025 23:19 View deployment

vercel bot deployed to Preview – onchainkit January 19, 2025 23:19 View deployment

vercel bot deployed to Preview – onchainkit-coverage January 19, 2025 23:21 View deployment

vercel bot deployed to Preview – onchainkit-routes January 20, 2025 00:06 View deployment

github-actions bot added the pkg: core label Jan 20, 2025

vercel bot deployed to Preview – onchainkit-playground January 20, 2025 00:07 View deployment

vercel bot deployed to Preview – onchainkit January 20, 2025 00:07 View deployment

vercel bot deployed to Preview – onchainkit-coverage January 20, 2025 00:08 View deployment

brendan-defi requested review from dschlabach, cpcramer, alessey and abcrane123 January 21, 2025 01:45

alessey reviewed Jan 21, 2025

View reviewed changes

src/internal/components/Draggable/getDefaultStartingPosition.ts Outdated Show resolved Hide resolved

alessey reviewed Jan 21, 2025

View reviewed changes

src/internal/components/Draggable/useBoundedPosition.ts Outdated Show resolved Hide resolved

alessey reviewed Jan 21, 2025

View reviewed changes

src/internal/components/Draggable/useBoundedPosition.ts Outdated Show resolved Hide resolved

alessey reviewed Jan 21, 2025

View reviewed changes

src/core/utils/copyToClipboard.ts Show resolved Hide resolved

dschlabach reviewed Jan 21, 2025

View reviewed changes

src/internal/components/Draggable/useBoundedPosition.ts Outdated Show resolved Hide resolved

dschlabach reviewed Jan 21, 2025

View reviewed changes

src/internal/components/Draggable/Draggable.tsx Outdated Show resolved Hide resolved

brendan-defi force-pushed the chore/wi-qc branch from c4a6d55 to 7d840d5 Compare January 22, 2025 04:04

vercel bot deployed to Preview – onchainkit-routes January 22, 2025 04:04 View deployment

brendan-defi requested review from dschlabach and alessey January 22, 2025 04:05

vercel bot deployed to Preview – onchainkit-playground January 22, 2025 04:05 View deployment

vercel bot deployed to Preview – onchainkit January 22, 2025 04:06 View deployment

vercel bot deployed to Preview – onchainkit-coverage January 22, 2025 04:07 View deployment

alessey reviewed Jan 22, 2025

View reviewed changes

src/internal/components/CopyButton.tsx Outdated Show resolved Hide resolved

alessey reviewed Jan 22, 2025

View reviewed changes

src/internal/components/CopyButton.tsx Show resolved Hide resolved

vercel bot deployed to Preview – onchainkit-routes January 22, 2025 17:40 View deployment

vercel bot deployed to Preview – onchainkit-playground January 22, 2025 17:41 View deployment

vercel bot deployed to Preview – onchainkit January 22, 2025 17:41 View deployment

brendan-defi added 6 commits January 22, 2025 09:42

address from context, not wagmi

820ff67

cursor design in css

d4e4a1b

extract wallet draggable props to util

2489381

refactor draggable repositioning

b11482b

remove unused svg

38ed081

refactor draggable starting position utils

8f795ab

vercel bot deployed to Preview – onchainkit-coverage January 22, 2025 17:42 View deployment

brendan-defi added 9 commits January 22, 2025 09:42

extract copyToClipboard to core utility

740fd6f

fix lints

fe8def7

address comments

72c3985

fix tests

dad29cc

refactor to use copybutton

826baa1

refactor copy handlers

601b44b

fix lints

9cd2162

remove console log

6019cf8

fix tests, lints

785ff4e

brendan-defi force-pushed the chore/wi-qc branch from 0fab92e to 785ff4e Compare January 22, 2025 17:47

vercel bot deployed to Preview – onchainkit-routes January 22, 2025 17:47 View deployment

github-actions bot added the pkg: identity label Jan 22, 2025

vercel bot deployed to Preview – onchainkit-playground January 22, 2025 17:49 View deployment

vercel bot deployed to Preview – onchainkit January 22, 2025 17:49 View deployment

vercel bot deployed to Preview – onchainkit-coverage January 22, 2025 17:50 View deployment

brendan-defi requested a review from alessey January 22, 2025 18:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: WalletIsland Code Quality Fast Follows #1842

Chore: WalletIsland Code Quality Fast Follows #1842

brendan-defi commented Jan 19, 2025 •

edited

Loading

vercel bot commented Jan 19, 2025 •

edited

Loading

Chore: WalletIsland Code Quality Fast Follows #1842

Are you sure you want to change the base?

Chore: WalletIsland Code Quality Fast Follows #1842

Conversation

brendan-defi commented Jan 19, 2025 • edited Loading

vercel bot commented Jan 19, 2025 • edited Loading

brendan-defi commented Jan 19, 2025 •

edited

Loading

vercel bot commented Jan 19, 2025 •

edited

Loading