10.5 MDEV 34891 teemu #470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temeo
commented
Jan 7, 2025
temeo
commented
- MDEV-34891 : SST failure occurs when gtid_strict_mode is enabled
- Add suppression for transaction deadlock error.
- Add tests for wsrep GTID recovery with binlog on and off
- Initialize gtid seqno from recovered seqno when bootstrapping a new cluster
|
test_pr |
Problem was that initial GTID was set on wsrep_before_prepare out-of-order. In practice GTID was set to same as previous executed transaction GTID. In recovery valid GTID was found from prepared transaction and this transaction is committed leadin to fac that same GTID was executed twice. This is fixed by setting invalid GTID at wsrep_before_prepare and later in wsrep_before_commit actual correct GTID is set and this setting is done while we are in commit monitor i.e. assigment is done in order of replication. In recovery if prepared transaction is found we check its GTID, if it is invalid transaction will be rolled back and if it is valid it will be committed. Added two test cases for both mariabackup and rsync SST methods to show that GTIDs remain consistent on cluster and that all expected rows are in the table.
janlindstrom
force-pushed
the
10.5-MDEV-34891-teemu
branch
from
59619e8 to
37cb5d8
Compare
temeo
commented
Feb 3, 2025
| loose-galera-sst-rsync-gtid=1 | ||
|
|
||
| [mysqld.1] | ||
| wsrep_provider_options='[email protected].#galera_port;gcache.size=1;pc.weight=2;pc.ignore_sb=true' |
There was a problem hiding this comment.
Remove pc.ignore_sb, it is not needed when pc.weight=2. Copy EVS timeouts from top level galera_2nodes.cnf
| server-id=10 | ||
|
|
||
| [mysqld.2] | ||
| wsrep_provider_options='[email protected].#galera_port;gcache.size=1;pc.ignore_sb=true' |
There was a problem hiding this comment.
Remove pc.ignore_sb. Copy EVS timeouts from top level galera_2nodes.cnf.
| @@ -1,11 +1,11 @@ | |||
| --echo Performing --wsrep-recover ... | |||
| if ($wsrep_recover_additional) | |||
| { | |||
| --exec $MYSQLD --defaults-group-suffix=.$galera_wsrep_recover_server_id --defaults-file=$MYSQLTEST_VARDIR/my.cnf --log-error=$MYSQL_TMP_DIR/galera_wsrep_recover.log --innodb --wsrep-recover $wsrep_recover_additional > $MYSQL_TMP_DIR/galera_wsrep_recover.log 2>&1 | |||
| --exec $MYSQLD --defaults-group-suffix=.$galera_wsrep_recover_server_id --defaults-file=$MYSQLTEST_VARDIR/my.cnf --log-error=$MYSQL_TMP_DIR/galera_wsrep_recover.log --innodb --wsrep-debug=1 --wsrep-recover $wsrep_recover_additional > $MYSQL_TMP_DIR/galera_wsrep_recover.log 2>&1 | |||
There was a problem hiding this comment.
Is it necessary to have --wsrep-debug here and below? Wsrep debug is quite verbose and increases log sizes significantly.
There was a problem hiding this comment.
It was used to debug issue, I will remove it.
| [mysqld] | ||
| wsrep_sst_method=mariabackup | ||
| wsrep_sst_auth="root:" | ||
| wsrep_debug=1 |
| loose-galera-sst-mariabackup-gtid=1 | ||
|
|
||
| [mysqld.1] | ||
| wsrep_provider_options='[email protected].#galera_port;gcache.size=1;pc.weight=2;pc.ignore_sb=true' |
There was a problem hiding this comment.
Remove pc.ignore_sb, it is not needed when pc.weight=2. Copy EVS timeouts from top level galera_2nodes.cnf
| server-id=10 | ||
|
|
||
| [mysqld.2] | ||
| wsrep_provider_options='[email protected].#galera_port;gcache.size=1;pc.ignore_sb=true' |
There was a problem hiding this comment.
Remove pc.ignore_sb. Copy EVS timeouts from top level galera_2nodes.cnf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.