Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search to competition page #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saranshgrover
Copy link

You can filter competitors by their name. @coder13 The implementation is relatively straightforward but lmk if you don't like where I put something & I can change!

@netlify
Copy link

netlify bot commented Mar 9, 2023

Deploy Preview for competition-groups ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/competition-groups/deploys/6409e93baadbf70e584a99e5
😎 Deploy Preview https://deploy-preview-8--competition-groups.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coder13
Copy link
Owner

coder13 commented Mar 9, 2023

A couple of quick QOL requests:
Can you change the cursor for the X icon to be a pointer?
Can you also add a simple button just below the search results to quickly clear the search query?

I'm also not sure if the search bar needs a label or helper text, it likely should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants